Repository navigation
EC2: fix interface endpoint ENI IP, security groups and MAC format - #304
Open
nik-localstack wants to merge 2 commits into
Open
nik-localstack wants to merge 2 commits into
nik-localstack wants to merge 2 commits into
Conversation
(cherry picked from commit 9458b82)
…'s security groups create_vpc_endpoint gave the endpoint's network interface a random private IP outside the subnet and the VPC's default security group. It now lets create_network_interface pick an address from the subnet, applies the requested security groups, and marks the interface as a requester-managed vpc_endpoint interface in use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Interface VPC endpoints' network interfaces get a random private IP outside their subnet and the VPC's default security group instead of the endpoint's, and every ENI's MAC address is malformed (e.g.
2:4a:...instead of02:4a:...). Tracked as AWS-2745.Changes
create_vpc_endpointletscreate_network_interfaceallocate an IP from the subnet, applies the requested security groups, and sets the interface asvpc_endpoint, requester-managed andin-use, as AWS does.@aws_verifiedtesttest_create_interface_vpc_endpoint_network_interfaces: passes against AWS and moto, and fails without the fix.Only newly created endpoints are affected; ENIs already in persisted state keep their old values.
🤖 Generated with Claude Code